[DOCS] Remove soft limit for snapshot repositories #80745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodewig
added
>docs
jrodewig
changed the title
jrodewig
added
the
:Distributed Coordination/Snapshot/Restore
jrodewig
commented
Nov 15, 2021
Comment on lines
-275
to
-278
| While not a hard limit, a snapshot repository shouldn't contain more than | ||
| {max-snapshot-count} snapshots at a time. This ensures the repository's metadata | ||
| doesn't grow to a size that may destabilize the master node. We recommend you | ||
| set up your {slm-init} policy's retention rules to enforce this limit. |
There was a problem hiding this comment.
@original-brownbear Let me know if we want to offer any guidance to users for sizing their snapshot repositories. I can also use this information to update the policy UI copy in Kibana.
There was a problem hiding this comment.
I'd say we shouldn't give a hard number here these days probably. Maybe we should just point out that the repository does scale to thousands of snapshots, but that larger repositories do require more memory/a larger master. Just to make it clear that people should have retention setup in SLM and can't outright run a snapshot every 5 minutes for the next 10 years without ever deleting anything?
As long as we at least make it clear that there are limits and master node costs here and that deletes are necessary eventually we're good I think.
There was a problem hiding this comment.
Thanks. I re-added some guidance based on your comment with 521dbb8. Let me know what you think.
If that looks good to you, I'll merge this and get a fix open for the Kibana UI.
elasticmachine
added
Team:Docs
|
Pinging @elastic/es-docs (Team:Docs) |
|
Pinging @elastic/es-distributed (Team:Distributed) |
16 tasks
original-brownbear
approved these changes
Nov 16, 2021
| snapshots you no longer need. | ||
|
|
||
| A snapshot repository can safely scale to thousands of snapshots. However, to | ||
| manage its metadata, a large repository requires more memory and disk space on |
There was a problem hiding this comment.
"disk space" is not true, sorry that was my unfortunate wording above. It's really just memory that's the limiting factor here.
There was a problem hiding this comment.
Thanks for the correction.
This was referenced Nov 16, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 16, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 16, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 16, 2021
As part of #74350, snapshot repositories no longer have a 200 snapshot soft limit. This removes docs related to the limit. # Conflicts: # docs/reference/slm/apis/slm-put.asciidoc # docs/reference/snapshot-restore/take-snapshot.asciidoc
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 16, 2021
As part of #74350, snapshot repositories no longer have a 200 snapshot soft limit. This removes docs related to the limit. # Conflicts: # docs/reference/slm/apis/slm-put.asciidoc # docs/reference/snapshot-restore/take-snapshot.asciidoc
jrodewig
added a commit
to elastic/kibana
that referenced
this pull request
Nov 17, 2021
With elastic/elasticsearch#74350, we no longer recommend a 200 snapshot soft limit for snapshot repositories or SLM policies. This removes a related sentence from the Snapshot Policy UI. It also updates the docs link to point to the [create snapshot docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/snapshots-take-snapshot.html), which include guidance on snapshot retention, rather than the [put SLM policy API docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/slm-api-put-policy.html). Relates to elastic/elasticsearch#80745
jrodewig
added a commit
to elastic/kibana
that referenced
this pull request
Nov 17, 2021
With elastic/elasticsearch#74350, we no longer recommend a 200 snapshot soft limit for snapshot repositories or SLM policies. This removes a related sentence from the Snapshot Policy UI. It also updates the docs link to point to the [create snapshot docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/snapshots-take-snapshot.html), which include guidance on snapshot retention, rather than the [put SLM policy API docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/slm-api-put-policy.html). Relates to elastic/elasticsearch#80745
jrodewig
added a commit
to elastic/kibana
that referenced
this pull request
Nov 17, 2021
With elastic/elasticsearch#74350, we no longer recommend a 200 snapshot soft limit for snapshot repositories or SLM policies. This removes a related sentence from the Snapshot Policy UI. It also updates the docs link to point to the [create snapshot docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/snapshots-take-snapshot.html), which include guidance on snapshot retention, rather than the [put SLM policy API docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/slm-api-put-policy.html). Relates to elastic/elasticsearch#80745
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Nov 20, 2021
With elastic/elasticsearch#74350, we no longer recommend a 200 snapshot soft limit for snapshot repositories or SLM policies. This removes a related sentence from the Snapshot Policy UI. It also updates the docs link to point to the [create snapshot docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/snapshots-take-snapshot.html), which include guidance on snapshot retention, rather than the [put SLM policy API docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/slm-api-put-policy.html). Relates to elastic/elasticsearch#80745
dmlemeshko
pushed a commit
to elastic/kibana
that referenced
this pull request
Nov 29, 2021
With elastic/elasticsearch#74350, we no longer recommend a 200 snapshot soft limit for snapshot repositories or SLM policies. This removes a related sentence from the Snapshot Policy UI. It also updates the docs link to point to the [create snapshot docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/snapshots-take-snapshot.html), which include guidance on snapshot retention, rather than the [put SLM policy API docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/slm-api-put-policy.html). Relates to elastic/elasticsearch#80745
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #74350, snapshot repositories no longer have a 200 snapshot soft limit. This removes docs related to the limit from 7.14+ branches.
cc @Leaf-Lin